mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/
synced 2025-04-19 20:58:31 +09:00
scsi: Constify struct pci_error_handlers
'struct pci_error_handlers' are not modified in these drivers. Constifying these structures moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig, as an example: Before: ====== text data bss dec hex filename 39049 6429 112 45590 b216 drivers/scsi/aacraid/linit.o After: ===== text data bss dec hex filename 39113 6365 112 45590 b216 drivers/scsi/aacraid/linit.o Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/efdec8425981e10fc398fa2ac599c9c45d930561.1737318548.git.christophe.jaillet@wanadoo.fr Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
2014c95afe
commit
14807b4a4e
@ -2029,7 +2029,7 @@ static void aac_pci_resume(struct pci_dev *pdev)
|
||||
dev_err(&pdev->dev, "aacraid: PCI error - resume\n");
|
||||
}
|
||||
|
||||
static struct pci_error_handlers aac_pci_err_handler = {
|
||||
static const struct pci_error_handlers aac_pci_err_handler = {
|
||||
.error_detected = aac_pci_error_detected,
|
||||
.mmio_enabled = aac_pci_mmio_enabled,
|
||||
.slot_reset = aac_pci_slot_reset,
|
||||
|
@ -5776,7 +5776,7 @@ static void beiscsi_remove(struct pci_dev *pcidev)
|
||||
}
|
||||
|
||||
|
||||
static struct pci_error_handlers beiscsi_eeh_handlers = {
|
||||
static const struct pci_error_handlers beiscsi_eeh_handlers = {
|
||||
.error_detected = beiscsi_eeh_err_detected,
|
||||
.slot_reset = beiscsi_eeh_reset,
|
||||
.resume = beiscsi_eeh_resume,
|
||||
|
@ -1642,7 +1642,7 @@ MODULE_DEVICE_TABLE(pci, bfad_id_table);
|
||||
/*
|
||||
* PCI error recovery handlers.
|
||||
*/
|
||||
static struct pci_error_handlers bfad_err_handler = {
|
||||
static const struct pci_error_handlers bfad_err_handler = {
|
||||
.error_detected = bfad_pci_error_detected,
|
||||
.slot_reset = bfad_pci_slot_reset,
|
||||
.mmio_enabled = bfad_pci_mmio_enabled,
|
||||
|
@ -1162,7 +1162,7 @@ err_resume_exit:
|
||||
dev_err(&pdev->dev, "resume of device failed: %d\n", rv);
|
||||
}
|
||||
|
||||
static struct pci_error_handlers csio_err_handler = {
|
||||
static const struct pci_error_handlers csio_err_handler = {
|
||||
.error_detected = csio_pci_error_detected,
|
||||
.slot_reset = csio_pci_slot_reset,
|
||||
.resume = csio_pci_resume,
|
||||
|
@ -735,7 +735,7 @@ efct_pci_io_resume(struct pci_dev *pdev)
|
||||
|
||||
MODULE_DEVICE_TABLE(pci, efct_pci_table);
|
||||
|
||||
static struct pci_error_handlers efct_pci_err_handler = {
|
||||
static const struct pci_error_handlers efct_pci_err_handler = {
|
||||
.error_detected = efct_pci_io_error_detected,
|
||||
.slot_reset = efct_pci_io_slot_reset,
|
||||
.resume = efct_pci_io_resume,
|
||||
|
@ -5803,7 +5803,7 @@ static const struct pci_device_id mpi3mr_pci_id_table[] = {
|
||||
};
|
||||
MODULE_DEVICE_TABLE(pci, mpi3mr_pci_id_table);
|
||||
|
||||
static struct pci_error_handlers mpi3mr_err_handler = {
|
||||
static const struct pci_error_handlers mpi3mr_err_handler = {
|
||||
.error_detected = mpi3mr_pcierr_error_detected,
|
||||
.mmio_enabled = mpi3mr_pcierr_mmio_enabled,
|
||||
.slot_reset = mpi3mr_pcierr_slot_reset,
|
||||
|
@ -12710,7 +12710,7 @@ static const struct pci_device_id mpt3sas_pci_table[] = {
|
||||
};
|
||||
MODULE_DEVICE_TABLE(pci, mpt3sas_pci_table);
|
||||
|
||||
static struct pci_error_handlers _mpt3sas_err_handler = {
|
||||
static const struct pci_error_handlers _mpt3sas_err_handler = {
|
||||
.error_detected = scsih_pci_error_detected,
|
||||
.mmio_enabled = scsih_pci_mmio_enabled,
|
||||
.slot_reset = scsih_pci_slot_reset,
|
||||
|
@ -2876,7 +2876,7 @@ MODULE_DEVICE_TABLE(pci, qedi_pci_tbl);
|
||||
|
||||
static enum cpuhp_state qedi_cpuhp_state;
|
||||
|
||||
static struct pci_error_handlers qedi_err_handler = {
|
||||
static const struct pci_error_handlers qedi_err_handler = {
|
||||
.error_detected = qedi_io_error_detected,
|
||||
};
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user